Re: [PATCH v4 0/3] improve get_feat.pl output when all features are displayed

From: Jonathan Corbet
Date: Fri Dec 04 2020 - 16:49:26 EST


On Fri, 4 Dec 2020 16:32:27 +0100
Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx> wrote:

> As requested, those patches improve the output of the script, when all features
> are displayed.
>
> The first patch was already posted as-is at v3.
>
> Patch 2 is optional. IMO, it makes more sense for the admin guide to show
> the architectures where the features are OK, then TODO, and finally the
> ones that are incompatible with the features. I already sent it together
> with a comment.
>
> Patch 3 is new: it tries to reduce the width of the table, in order for it
> to better fit on a terminal. With the patch, the number of columns were
> reduced, in order to better fit at console output. Before the patch, the
> output takes 281 lines with 158 columns (total size: 38.9 kB).
> After the patch, displaying all features require 439 lines and 92 columns
> (total size: 37.6 kB).

OK, this is much improved, thanks; applied.

The one last thing I would do is stick "valign=top" on all the table
entries, but we can leave the shed a different color for now :)

Thanks,

jon