Re: [PATCH v3 2/4] configfs: use (1UL << bit) for internal flags

From: Bartosz Golaszewski
Date: Fri Dec 04 2020 - 15:24:48 EST


On Fri, Dec 4, 2020 at 8:06 PM Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:
>
>
>
> On Friday, December 4, 2020, Bartosz Golaszewski <brgl@xxxxxxxx> wrote:
>>
>> From: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>
>>
>> For better readability and maintenance: use the (1UL << bit) for flag
>> definitions.
>>
>
> And I didn’t get why BIT can’t be used?
> Maybe some elaboration?
>

I agree that BIT() would be better and did try it in v2[1].

Bartosz

[1] https://www.mail-archive.com/linux-kernel@xxxxxxxxxxxxxxx/msg2398294.html