Re: [PATCH] dpaa_eth: fix build errorr in dpaa_fq_init

[Jakub Kicinski]

On Thu, 3 Dec 2020 15:49:21 +0100 Björn Töpel wrote:
> On Thu, 3 Dec 2020 at 15:46, Anders Roxell <anders.roxell@xxxxxxxxxx> wrote:
> >
> > When building FSL_DPAA_ETH the following build error shows up:
> >
> > /tmp/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c: In function ‘dpaa_fq_init’:
> > /tmp/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c:1135:9: error: too few arguments to function ‘xdp_rxq_info_reg’
> >  1135 |   err = xdp_rxq_info_reg(&dpaa_fq->xdp_rxq, dpaa_fq->net_dev,
> >       |         ^~~~~~~~~~~~~~~~
> >
> > Commit b02e5a0ebb17 ("xsk: Propagate napi_id to XDP socket Rx path")
> > added an extra argument to function xdp_rxq_info_reg and commit
> > d57e57d0cd04 ("dpaa_eth: add XDP_TX support") didn't know about that
> > extra argument.
> >
> > Signed-off-by: Anders Roxell <anders.roxell@xxxxxxxxxx>
> > ---
> >
> > I think this issue is seen since both patches went in at the same time
> > to bpf-next and net-next.
> >  
> 
> Thanks Anders!
> 
> Indeed, when bpf-next is pulled into net-next this needs to be applied.
> 
> Acked-by: Björn Töpel <bjorn.topel@xxxxxxxxx>

Applied, thanks!

Looks like there is a mention of this function in an
example in Documentation/ that may need updating, too.