Re: [PATCH v2 0/2] Adds support to capture module's SCM version

From: Christoph Hellwig
Date: Fri Dec 04 2020 - 13:18:59 EST


On Fri, Dec 04, 2020 at 10:13:56AM -0800, Will McVicker wrote:
> On Fri, Dec 04, 2020 at 07:51:59AM +0000, Christoph Hellwig wrote:
> > I think your decription still shows absolutely no benefit for the
> > kernel, so I'not sure why anyone would want to waste time on this.
> Hi Christoph,
>
> Did you get a chance to read my earlier responses regarding the uses for
> in-tree modules?
>
> The biggest benefit for the upstream community is being about to get the SCM
> version for *any* module (including in-tree modules) in the initramfs via the
> sysfs node. Currently there is no way to do that and there is no guarantee that

That assumes the SCM version of a module has any kind of meaning for
an in-tree module. Which it doesn't. If you care about the SCM version
of an in-tree module the only thing we need is one single global sysfs
file.