Re: [PATCH] btrfs: free-space-cache: Fix error return code in __load_free_space_cache

From: David Sterba
Date: Fri Dec 04 2020 - 12:54:25 EST


On Fri, Nov 20, 2020 at 09:08:04AM +0800, Zhihao Cheng wrote:
> Fix to return the error code(instead always 0) when memory allocating
> failed in __load_free_space_cache().

This lacks the analysis of consequences, so there's only one caller and
that will treat values <=0 as 'cache not loaded'. There's no functional
change but otherwise the error values should be there for clarity.
Changelog updated.

> Fixes: a67509c30079f4c50 ("Btrfs: add a io_ctl struct and helpers ...")

BTW, please don't trim the patch subject in the Fixes line.