Re: [PATCH] cpufreq: scmi: add COMMON_CLK dependency

[Sudeep Holla]

On Fri, Dec 04, 2020 at 12:17:46AM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> Wtihout CONFIG_COMMON_CLK, the scmi driver fails to link:
>
> arm-linux-gnueabi-ld: drivers/cpufreq/scmi-cpufreq.o: in function `scmi_cpufreq_probe':
> scmi-cpufreq.c:(.text+0x20c): undefined reference to `devm_of_clk_add_hw_provider'
> arm-linux-gnueabi-ld: scmi-cpufreq.c:(.text+0x22c): undefined reference to `of_clk_hw_simple_get'
>
> Add a Kconfig dependency for it.
>

There is a fix already upstream in later -rc(rc6 IIRC), I assume you are
seeing this prior to that.

Commit f943849f7206 ("cpufreq: scmi: Fix build for !CONFIG_COMMON_CLK")

Since the only dependency on CONFIG_COMMON_CLK is to satisfy OPP adding
dummy clock provider, I avoided adding dependency on CLK for this driver
as this works fine for !CONFIG_COMMON_CLK.

--
Regards,
Sudeep

P.S: There are 2 copies of this patch, I chose to reply on this, other
one is @[1]

[1] https://lore.kernel.org/lkml/20201203225550.1478195-1-arnd@xxxxxxxxxx