Re: [f2fs-dev] [PATCH] f2fs: fix race of pending_pages in decompression

[Daeho Jeong]

Eric,

I have another question.
I understand enabling the verity can be possible in the middle of I/O.
Is the opposite way also possible? Actually, I couldn't find any
disabling function of it, though.

2020년 12월 4일 (금) 오후 1:31, Daeho Jeong <daeho43@xxxxxxxxx>님이 작성:
>
> > Are you sure?  I thought that compression (and encryption) apply to the whole
> > file, including any Merkle tree blocks past i_size.
>
> This "dic" structure is only for "de"compression, so we don't need to
> worry about going beyond i_size case.
>
> > Also, even if you include the i_size check, it's still wrong to check
> > fsverity_active() in the middle of the I/O because FS_IOC_ENABLE_VERITY can
> > execute concurrently, causing fsverity_active() to return false at the beginning
> > of the I/O and true later in the I/O.  It needs to be checked only once, at the
> > beginning...
>
> Got it. Our previous implementation didn't consider this case. Need to fix this.
>
> Thanks,