Re: [PATCH] phy: mediatek: allow compile-testing the hdmi phy

From: Chunfeng Yun
Date: Thu Dec 03 2020 - 20:48:10 EST


On Thu, 2020-12-03 at 23:54 +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> Compile-testing the DRM_MEDIATEK_HDMI driver leads to a harmless
> warning:
>
> WARNING: unmet direct dependencies detected for PHY_MTK_HDMI
> Depends on [n]: ARCH_MEDIATEK [=n] && OF [=y]
> Selected by [y]:
> - DRM_MEDIATEK_HDMI [=y] && HAS_IOMEM [=y] && DRM_MEDIATEK [=y]
>
> The driver builds fine, so allow compile-testing it as well
> to get rid of the warning.
>
> Fixes: b28be59a2e26 ("phy: mediatek: Move mtk_hdmi_phy driver into drivers/phy/mediatek folder")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
> drivers/phy/mediatek/Kconfig | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/phy/mediatek/Kconfig b/drivers/phy/mediatek/Kconfig
> index 65ed26e40c9f..29a85b2738f8 100644
> --- a/drivers/phy/mediatek/Kconfig
> +++ b/drivers/phy/mediatek/Kconfig
> @@ -40,7 +40,9 @@ config PHY_MTK_XSPHY
>
> config PHY_MTK_HDMI
> tristate "MediaTek HDMI-PHY Driver"
> - depends on ARCH_MEDIATEK && OF
> + depends on ARCH_MEDIATEK || COMPILE_TEST
> + depends on COMMON_CLK
Seems no need add COMMON_CLK here

> + depends on OF
> select GENERIC_PHY
> help
> Support HDMI PHY for Mediatek SoCs.