Re: [PATCH] watchdog: coh901327: add COMMON_CLK dependency

[Guenter Roeck]

On Thu, Dec 03, 2020 at 11:33:42PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
> 
> clang produces a build failure in configurations without COMMON_CLK
> when a timeout calculation goes wrong:
> 
> arm-linux-gnueabi-ld: drivers/watchdog/coh901327_wdt.o: in function `coh901327_enable':
> coh901327_wdt.c:(.text+0x50): undefined reference to `__bad_udelay'
> 
> Add a Kconfig dependency to only do build testing when COMMON_CLK
> is enabled.
> 
> Fixes: da2a68b3eb47 ("watchdog: Enable COMPILE_TEST where possible")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>

> ---
>  drivers/watchdog/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index 8bdbd125821b..32fa6de7b820 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -631,7 +631,7 @@ config SUNXI_WATCHDOG
>  
>  config COH901327_WATCHDOG
>  	bool "ST-Ericsson COH 901 327 watchdog"
> -	depends on ARCH_U300 || (ARM && COMPILE_TEST)
> +	depends on ARCH_U300 || (ARM && COMMON_CLK && COMPILE_TEST)
>  	default y if MACH_U300
>  	select WATCHDOG_CORE
>  	help
> -- 
> 2.27.0
>