Re: [PATCH] intel_idle: fix intel_idle_state_needs_timer_stop build failure

From: Randy Dunlap
Date: Thu Dec 03 2020 - 18:13:34 EST


On 12/3/20 2:30 PM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> The newly added function is defined inside of an #ifdef section but
> used outside, leading to a build failure:
>
> drivers/idle/intel_idle.c:1510:7: error: implicit declaration of function 'intel_idle_state_needs_timer_stop' [-Werror,-Wimplicit-function-declaration]
> if (intel_idle_state_needs_timer_stop(&drv->states[drv->state_count]))
> ^
>
> Move it ahead of the CONFIG_ACPI_PROCESSOR_CSTATE check.
>
> Fixes: 6e1d2bc675bd ("intel_idle: Fix intel_idle() vs tracing")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
> drivers/idle/intel_idle.c | 28 ++++++++++++++--------------
> 1 file changed, 14 insertions(+), 14 deletions(-)
>

Peter has already fixed this one.

thanks.
--
~Randy