Re: [PATCH bpf-next v3 12/14] bpf: Pull tools/build/feature biz into selftests Makefile

From: Andrii Nakryiko
Date: Thu Dec 03 2020 - 16:02:20 EST


On Thu, Dec 3, 2020 at 8:07 AM Brendan Jackman <jackmanb@xxxxxxxxxx> wrote:
>
> This is somewhat cargo-culted from the libbpf build. It will be used
> in a subsequent patch to query for Clang BPF atomics support.
>
> Change-Id: I9318a1702170eb752acced35acbb33f45126c44c

Haven't seen this before. What's this Change-Id business?

> Signed-off-by: Brendan Jackman <jackmanb@xxxxxxxxxx>
> ---
> tools/testing/selftests/bpf/.gitignore | 1 +
> tools/testing/selftests/bpf/Makefile | 38 ++++++++++++++++++++++++++
> 2 files changed, 39 insertions(+)

All this just to detect the support for clang atomics?... Let's not
pull in the entire feature-detection framework unnecessarily,
selftests Makefile is complicated enough without that.

[...]