Re: [PATCH v7 1/7] mtd: spi-nor: sst: fix BPn bits for the SST25VF064C

From: Michael Walle
Date: Thu Dec 03 2020 - 09:40:37 EST


Am 2020-12-03 15:34, schrieb Tudor.Ambarus@xxxxxxxxxxxxx:
On 12/3/20 1:00 AM, Michael Walle wrote:
EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

This flash part actually has 4 block protection bits.

Reported-by: Tudor Ambarus <tudor.ambarus@xxxxxxxxxxxxx>
Cc: stable@xxxxxxxxxxxxxxx # v5.7+

While the patch is correct according to the datasheet, it was
not tested, so it's not a candidate for stable. I would update
the commit message to indicate that the the patch was made
solely on datasheet info and not tested, I would add the fixes
tag, and strip cc-ing to stable.

What is the difference? Any commit with a Fixes tag will also land
in the stable trees. Just that it will cause compile errors for
kernel older than 5.7.

So if you don't want to have it in stable then you must not add
a Fixes: tag either.

-michael