RE: [PATCH v2 0/5] memory: renesas-rpc-if: Trivial fixes

From: Prabhakar Mahadev Lad
Date: Thu Dec 03 2020 - 07:35:39 EST


Hi Geert,

> -----Original Message-----
> From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Sent: 03 December 2020 10:52
> To: Lad, Prabhakar <prabhakar.csengg@xxxxxxxxx>
> Cc: Krzysztof Kozlowski <krzk@xxxxxxxxxx>; Sergei Shtylyov <sergei.shtylyov@xxxxxxxxx>; Prabhakar
> Mahadev Lad <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>; Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>; Jiri
> Kosina <trivial@xxxxxxxxxx>; Mark Brown <broonie@xxxxxxxxxx>; Linux-Renesas <linux-renesas-
> soc@xxxxxxxxxxxxxxx>; Pavel Machek <pavel@xxxxxxx>; Geert Uytterhoeven <geert+renesas@xxxxxxxxx>; LKML
> <linux-kernel@xxxxxxxxxxxxxxx>
> Subject: Re: [PATCH v2 0/5] memory: renesas-rpc-if: Trivial fixes
>
> Hi Prabhakar,
>
> On Thu, Dec 3, 2020 at 11:42 AM Lad, Prabhakar
> <prabhakar.csengg@xxxxxxxxx> wrote:
> > On Thu, Nov 26, 2020 at 7:11 PM Lad Prabhakar
> > <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> wrote:
> > > This patch series fixes trivial issues in RPC-IF driver.
> > >
> > > Changes for v2:
> > > * Balanced PM in rpcif_disable_rpm
> > > * Fixed typo in patch 4/5
> > > * Dropped C++ style fixes patch
> > > * Included RB tags from Sergei
> > >
> > > Cheers,
> > > Prabhakar
> > >
> > > Lad Prabhakar (5):
> > > memory: renesas-rpc-if: Return correct value to the caller of
> > > rpcif_manual_xfer()
> > > memory: renesas-rpc-if: Fix unbalanced pm_runtime_enable in
> > > rpcif_{enable,disable}_rpm
> > > memory: renesas-rpc-if: Fix a reference leak in rpcif_probe()
> > > memory: renesas-rpc-if: Make rpcif_enable/disable_rpm() as static
> > > inline
> > > memory: renesas-rpc-if: Export symbols as GPL
> > >
> > As these are fixes to the existing driver will these be part of v5.10 release ?
>
> IIUIC, only the first one[*] is a fix for an issue that could happen during
> normal operation?
>
Agreed (Btw I was referring to top 3 patches).

Cheers,
Prabhakar

> [*] -EPROBE_DEFER would be eaten, causing no reprobe to happen.
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds