Re: [PATCH bpf-next v9 00/34] bpf: switch to memcg-based memory accounting

From: Alexei Starovoitov
Date: Wed Dec 02 2020 - 21:55:41 EST


On Tue, Dec 1, 2020 at 1:59 PM Roman Gushchin <guro@xxxxxx> wrote:
>
> 5) Cryptic -EPERM is returned on exceeding the limit. Libbpf even had
> a function to "explain" this case for users.
...
> v9:
> - always charge the saved memory cgroup, by Daniel, Toke and Alexei
> - added bpf_map_kzalloc()
> - rebase and minor fixes

This looks great. Applied.
Please follow up with a change to libbpf's pr_perm_msg().
That helpful warning should stay for old kernels, but it would be
misleading for new kernels.
libbpf probably needs a feature check to make this warning conditional.

Thanks!