Re: [PATCH v2 net-next] net: ipa: fix build-time bug in ipa_hardware_config_qsb()

From: Jakub Kicinski
Date: Wed Dec 02 2020 - 20:20:24 EST


On Wed, 2 Dec 2020 08:15:02 -0600 Alex Elder wrote:
> Jon Hunter reported observing a build bug in the IPA driver:
> https://lore.kernel.org/netdev/5b5d9d40-94d5-5dad-b861-fd9bef8260e2@xxxxxxxxxx
>
> The problem is that the QMB0 max read value set for IPA v4.5 (16) is
> too large to fit in the 4-bit field.
>
> The actual value we want is 0, which requests that the hardware use
> the maximum it is capable of.
>
> Reported-by: Jon Hunter <jonathanh@xxxxxxxxxx>
> Tested-by: Jon Hunter <jonathanh@xxxxxxxxxx>
> Signed-off-by: Alex Elder <elder@xxxxxxxxxx>

Applied, thanks!