Re: [PATCH 4/4] thermal/core: Remove ms based delay fields
From: kernel test robot
Date: Wed Dec 02 2020 - 12:46:06 EST
Hi Daniel,
I love your patch! Yet something to improve:
[auto build test ERROR on linux/master]
[also build test ERROR on linus/master v5.10-rc6 next-20201201]
[cannot apply to thermal/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Daniel-Lezcano/thermal-core-Rename-passive_delay-and-polling_delay-with-units/20201202-201150
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 09162bc32c880a791c6c0668ce0745cf7958f576
config: nios2-randconfig-r021-20201202 (attached as .config)
compiler: nios2-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/6882dfdda2ded695a08357272d350db4e24fe59d
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Daniel-Lezcano/thermal-core-Rename-passive_delay-and-polling_delay-with-units/20201202-201150
git checkout 6882dfdda2ded695a08357272d350db4e24fe59d
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=nios2
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>
All errors (new ones prefixed by >>):
drivers/thermal/thermal_core.c: In function 'monitor_thermal_zone':
>> drivers/thermal/thermal_core.c:316:24: error: 'struct thermal_zone_device' has no member named 'polling_delay_ms'; did you mean 'polling_delay_jiffies'?
316 | else if (!stop && tz->polling_delay_ms)
| ^~~~~~~~~~~~~~~~
| polling_delay_jiffies
vim +316 drivers/thermal/thermal_core.c
b56bdff78e0b65f drivers/thermal/thermal_core.c Andrzej Pietrasiewicz 2020-06-29 305
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c Durgadoss R 2012-09-18 306 static void monitor_thermal_zone(struct thermal_zone_device *tz)
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c Durgadoss R 2012-09-18 307 {
b56bdff78e0b65f drivers/thermal/thermal_core.c Andrzej Pietrasiewicz 2020-06-29 308 bool stop;
b56bdff78e0b65f drivers/thermal/thermal_core.c Andrzej Pietrasiewicz 2020-06-29 309
b56bdff78e0b65f drivers/thermal/thermal_core.c Andrzej Pietrasiewicz 2020-06-29 310 stop = should_stop_polling(tz);
b56bdff78e0b65f drivers/thermal/thermal_core.c Andrzej Pietrasiewicz 2020-06-29 311
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c Durgadoss R 2012-09-18 312 mutex_lock(&tz->lock);
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c Durgadoss R 2012-09-18 313
b56bdff78e0b65f drivers/thermal/thermal_core.c Andrzej Pietrasiewicz 2020-06-29 314 if (!stop && tz->passive)
07314bdc38fa26c drivers/thermal/thermal_core.c Daniel Lezcano 2020-12-02 315 thermal_zone_device_set_polling(tz, tz->passive_delay_jiffies);
ade78f158731d79 drivers/thermal/thermal_core.c Daniel Lezcano 2020-12-02 @316 else if (!stop && tz->polling_delay_ms)
07314bdc38fa26c drivers/thermal/thermal_core.c Daniel Lezcano 2020-12-02 317 thermal_zone_device_set_polling(tz, tz->polling_delay_jiffies);
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c Durgadoss R 2012-09-18 318 else
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c Durgadoss R 2012-09-18 319 thermal_zone_device_set_polling(tz, 0);
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c Durgadoss R 2012-09-18 320
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c Durgadoss R 2012-09-18 321 mutex_unlock(&tz->lock);
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c Durgadoss R 2012-09-18 322 }
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c Durgadoss R 2012-09-18 323
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip