Re: [PATCH v4 3/7] mfd: Add base driver for Netronix embedded controller

[Jonathan Neuschäfer]

On Wed, Dec 02, 2020 at 03:09:43PM +0000, Lee Jones wrote:
> On Wed, 02 Dec 2020, Jonathan Neuschäfer wrote:
> 
> > On Wed, Dec 02, 2020 at 01:05:20PM +0000, Lee Jones wrote:
> > > On Sun, 22 Nov 2020, Jonathan Neuschäfer wrote:
> > [...]
> > > > +	/* Bail out if we encounter an unknown firmware version */
> > > > +	switch (version) {
> > > > +	case 0xd726: /* found in Kobo Aura */
> > > 
> > > No magic numbers.
> > > 
> > > Please submit a subsequent patch to define this.
> > 
> > Will do.
> > 
> > But I don't think I'll be able to give it a more meaningful name than
> > NTXEC_VERSION_D726. I don't have a good overview of which versions
> > appear in which devices. "0xd726 found in Kobo Aura" only means that;
> > I don't know if it's the only version used in the Kobo Aura, and I don't
> > know if the Kobo Aura is the only device where it is used.
> 
> Defines are not set in stone.
> 
> They can evolve over time as more is known.
> 
> NTXEC_KOBO_AURA would be fine for now.

Alright.


Thanks,
Jonathan Neuschäfer

Attachment: signature.asc
Description: PGP signature