Re: [PATCH 00/29] MHI changes for v5.11

[Manivannan Sadhasivam]

Hi Greg,

On Wed, Dec 02, 2020 at 03:11:30PM +0530, Manivannan Sadhasivam wrote:
> Hi Greg,
> 
> Here is the MHI patch series for v5.11. It was a busy cycle for us and so far we
> have accumulated almost 29 patches. Most of the patches are cleanups and fixes
> but there are some noticeable changes too:
> 
> 1. Loic finally removed the auto-start option from the channel parameters of the
> MHI controller. It is the duty of the client drivers like qrtr to start/stop the
> channels when required, so we decided to remove this option. As a side effect,
> we changed the qrtr driver to start the channels during its probe and removed
> the auto-start option from ath11k controller.
> 
> **NOTE** Since these changes spawns both MHI and networking trees, the patches
> are maintained in an immutable branch [1] and pulled into both mhi-next and
> ath11k-next branches. The networking patches got acks from ath11k and networking
> maintainers as well.
> 

Sigh... this is not going to work for patches in email form due to the immutable
branch. I will send a pull request this time.

Please ignore this series.

Thanks,
Mani

> 2. Loic added a generic MHI pci controller driver. This driver will be used by
> the PCI based Qualcomm modems like SDX55 and exposes channels such as QMI,
> IP_HW0, IPCR etc...
> 
> 3. Loic fixed the MHI device hierarchy by maintaining the correct parent child
> relationships. Earlier all MHI devices lived in the same level under the parent
> device like PCIe. But now, the MHI devices belonging to channels will become the
> children of controller MHI device.
> 
> 4. Finally Loic also improved the MHI device naming by using indexed names such
> as mhi0, mhi1, etc... This will break the userspace applications depending on
> the old naming convention but since the only one user so far is Jeff Hugo's AI
> accelerator apps, we decided to make this change now itself with his agreement.
> 
> 5. Bhaumik fixed the qrtr driver by stopping the channels during remove. This
> patch also got ack from networking maintainer and we decided to take it through
> MHI tree (via immutable branch) since we already had a qrtr change.
> 
> Please consider applying!
> 
> Thanks,
> Mani
> 
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/mani/mhi.git/log/?h=mhi-ath11k-immutable
> 
> Bhaumik Bhatt (19):
>   bus: mhi: core: Remove unnecessary counter from mhi_firmware_copy()
>   bus: mhi: core: Add missing EXPORT_SYMBOL for mhi_get_mhi_state()
>   bus: mhi: core: Expose mhi_get_exec_env() API for controllers
>   bus: mhi: core: Remove unused mhi_fw_load_worker() declaration
>   bus: mhi: core: Rename RDDM download function to use proper words
>   bus: mhi: core: Skip RDDM download for unknown execution environment
>   bus: mhi: core: Use appropriate names for firmware load functions
>   bus: mhi: core: Move to using high priority workqueue
>   bus: mhi: core: Skip device wake in error or shutdown states
>   bus: mhi: core: Move to SYS_ERROR regardless of RDDM capability
>   bus: mhi: core: Prevent sending multiple RDDM entry callbacks
>   bus: mhi: core: Move to an error state on any firmware load failure
>   bus: mhi: core: Use appropriate label in firmware load handler API
>   bus: mhi: core: Move to an error state on mission mode failure
>   bus: mhi: core: Check for IRQ availability during registration
>   bus: mhi: core: Separate system error and power down handling
>   bus: mhi: core: Mark and maintain device states early on after power
>     down
>   bus: mhi: core: Remove MHI event ring IRQ handlers when powering down
>   net: qrtr: Unprepare MHI channels during remove
> 
> Carl Yin (1):
>   bus: mhi: core: Fix null pointer access when parsing MHI configuration
> 
> Dan Carpenter (1):
>   bus: mhi: core: Fix error handling in mhi_register_controller()
> 
> Jeffrey Hugo (1):
>   bus: mhi: core: fix potential operator-precedence with BHI macros
> 
> Loic Poulain (7):
>   bus: mhi: Remove auto-start option
>   net: qrtr: Start MHI channels during init
>   bus: mhi: Add MHI PCI support for WWAN modems
>   bus: mhi: Fix channel close issue on driver remove
>   bus: mhi: core: Indexed MHI controller name
>   bus: mhi: core: Fix device hierarchy
>   mhi: pci_generic: Fix implicit conversion warning
> 
> -- 
> 2.25.1
>