Re: [PATCH v2 bpf-next 01/13] bpf: x86: Factor out emission of ModR/M for *(reg + off)

[Alexei Starovoitov]

On Tue, Dec 1, 2020 at 4:14 AM Brendan Jackman <jackmanb@xxxxxxxxxx> wrote:
>
> On Sat, Nov 28, 2020 at 05:15:52PM -0800, Alexei Starovoitov wrote:
> > On Fri, Nov 27, 2020 at 05:57:26PM +0000, Brendan Jackman wrote:
> > > +/* Emit the ModR/M byte for addressing *(r1 + off) and r2 */
> > > +static void emit_modrm_dstoff(u8 **pprog, u32 r1, u32 r2, int off)
> >
> > same concern as in the another patch. If you could avoid intel's puzzling names
> > like above it will make reviewing the patch easier.
>
> In this case there is actually a call like
>
>   emit_modrm_dstoff(&prog, src_reg, dst_reg)

emit_insn_prefix() ?