Re: [PATCH v2 1/4] x86/signal: Introduce helpers to get the maximum signal frame size

From: Borislav Petkov
Date: Tue Dec 01 2020 - 09:27:57 EST


On Mon, Nov 30, 2020 at 08:40:32PM +0000, Bae, Chang Seok wrote:
> In general, putting #ifdef in a C file is advised to avoid.

Well, in this case it is arguably better to have the ifdeffery there,
where it is being used.

> I wonder whether it is okay to include #ifdef in the C file in this
> case.

Yes, it's not like this will be the only place where you have #ifdef in
a .c file:

[ ~/kernel/linux> git grep "#ifdef" *.c | wc -l
29401

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette