Re: crypto: sun4i-ss: error with kmap

From: Thomas Gleixner
Date: Tue Dec 01 2020 - 09:17:39 EST


On Tue, Dec 01 2020 at 14:52, Corentin Labbe wrote:
> On Tue, Dec 01, 2020 at 02:28:54PM +0100, Thomas Gleixner wrote:
> The patch made the board too busy logging and fail to boot until the test.

Stupid me. Of course this wants to be conditional.

Thanks,

tglx
---
diff --git a/mm/highmem.c b/mm/highmem.c
index b49364a306b8..178b126ab4f6 100644
--- a/mm/highmem.c
+++ b/mm/highmem.c
@@ -571,8 +571,10 @@ void kunmap_local_indexed(void *vaddr)
* PAGE_OFFSET. Warn for all other addresses which are in
* the user space part of the virtual address space.
*/
- if (!kmap_high_unmap_local(addr))
- WARN_ON_ONCE(addr < PAGE_OFFSET);
+ if (!kmap_high_unmap_local(addr)) {
+ if (WARN_ON_ONCE(addr < PAGE_OFFSET))
+ pr_err("kunmap_local: vaddr %lx\n", (unsigned long) vaddr);
+ }
return;
}