Re: [PATCH v3 0/2] phy: ralink: phy-mt7621-pci: some fixes for COMPILE_TEST

From: Sergio Paracuellos
Date: Tue Dec 01 2020 - 06:58:36 EST


On Tue, Dec 1, 2020 at 12:44 PM Vinod Koul <vkoul@xxxxxxxxxx> wrote:
>
> On 01-12-20, 12:20, Sergio Paracuellos wrote:
> > Hi Vinod,
> >
> > After merging the phy-next tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> >
> > drivers/phy/ralink/phy-mt7621-pci.c:17:10: fatal error: mt7621.h: No such file or directory
> > 17 | #include <mt7621.h>
> > | ^~~~~~~~~~
> >
> > This driver has two includes which are in
> > "arch/mips/include/asm/mach-ralink" and are directly included in the
> > driver:
> > * mt7621.h
> > * ralink_regs.h
> >
> > This is because this path is directly included in 'arch/mips/ralink/Platform'
> > for "ralink".
> >
> > Adding the include search path to the phy ralink directory fix the problem but
> > as you told me I finally end up removing COMPILE_TEST from Kconfig.
> >
> > Making 'allmodconfig' in x86_64 also showed two warnings for this driver
> > because of pointer size and not valid name for MODULE_DEVICE_TABLE ids.
> >
> > Ids for the macro has been also included in this series.
>
> Applied, thanks
>

Thanks for letting me know.

Best regards,
Sergio Paracuellos
> --
> ~Vinod