Re: [PATCH] fanotify: Fix sys_fanotify_mark() on native x86-32

From: Jan Kara
Date: Tue Dec 01 2020 - 04:49:17 EST


On Mon 30-11-20 17:30:59, Brian Gerst wrote:
> Commit 121b32a58a3a converted native x86-32 which take 64-bit arguments to
> use the compat handlers to allow conversion to passing args via pt_regs.
> sys_fanotify_mark() was however missed, as it has a general compat handler.
> Add a config option that will use the syscall wrapper that takes the split
> args for native 32-bit.
>
> Reported-by: Paweł Jasiak <pawel@xxxxxxxxxx>
> Fixes: 121b32a58a3a ("x86/entry/32: Use IA32-specific wrappers for syscalls taking 64-bit arguments")
> Signed-off-by: Brian Gerst <brgerst@xxxxxxxxx>

Thanks for the patch! It looks good to me. Feel free to add:

Acked-by: Jan Kara <jack@xxxxxxx>

I assume you plan to push this via x86 tree given the changes are mostly
there, don't you?

Honza
--
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR