Re: [PATCH 5/5] ASoC/SoundWire: rt711-sdca: Add RT711 SDCA vendor-specific driver

From: Mark Brown
Date: Mon Nov 30 2020 - 13:18:27 EST


On Wed, Nov 04, 2020 at 01:22:26AM +0800, Bard Liao wrote:
> From: Shuming Fan <shumingf@xxxxxxxxxxx>
>
> This is the initial codec driver for rt711 SDCA version.

This and the rt1316 change are failing to build for me on both the
regmap tree and a merge of this branch into the ASoC tree in an x86
allmodconfig with the errors below, I assume this is a dependency on the
SoundWire tree which I guess I need a pull request for?

/mnt/kernel/sound/soc/codecs/rt1316-sdw.c: In function 'rt1316_read_prop':
/mnt/kernel/sound/soc/codecs/rt1316-sdw.c:83:6: error: 'struct sdw_slave_prop' has no member named 'is_sdca'
prop->is_sdca = true;
^~
/mnt/kernel/sound/soc/codecs/rt711-sdca-sdw.c: In function 'rt711_sdca_read_prop':
/mnt/kernel/sound/soc/codecs/rt711-sdca-sdw.c:182:6: error: 'struct sdw_slave_prop' has no member named 'is_sdca'
prop->is_sdca = true;
^~
In file included from /mnt/kernel/include/linux/printk.h:409,
from /mnt/kernel/include/linux/kernel.h:16,
from /mnt/kernel/include/linux/delay.h:22,
from /mnt/kernel/sound/soc/codecs/rt711-sdca-sdw.c:9:
/mnt/kernel/sound/soc/codecs/rt711-sdca-sdw.c: In function 'rt711_sdca_interrupt_callback':
/mnt/kernel/sound/soc/codecs/rt711-sdca-sdw.c:245:31: error: 'struct sdw_slave_intr_status' has no member named 'sdca_cascade'
status->control_port, status->sdca_cascade);
^~
/mnt/kernel/include/linux/dynamic_debug.h:129:15: note: in definition of macro '__dynamic_func_call'
func(&id, ##__VA_ARGS__); \
^~~~~~~~~~~
/mnt/kernel/include/linux/dynamic_debug.h:161:2: note: in expansion of macro '_dynamic_func_call'
_dynamic_func_call(fmt,__dynamic_dev_dbg, \
^~~~~~~~~~~~~~~~~~
/mnt/kernel/include/linux/dev_printk.h:123:2: note: in expansion of macro 'dynamic_dev_dbg'
dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
^~~~~~~~~~~~~~~
/mnt/kernel/sound/soc/codecs/rt711-sdca-sdw.c:243:2: note: in expansion of macro 'dev_dbg'
dev_dbg(&slave->dev,
^~~~~~~
/mnt/kernel/sound/soc/codecs/rt711-sdca-sdw.c:308:12: error: 'struct sdw_slave_intr_status' has no member named 'sdca_cascade'
if (status->sdca_cascade)
^~
make[4]: *** [/mnt/kernel/scripts/Makefile.build:283: sound/soc/codecs/rt1316-sdw.o] Error 1

Attachment: signature.asc
Description: PGP signature