Re: [PATCH] posix_acl.h: define missing ACL functions on non-posix-acl build

From: Randy Dunlap
Date: Sun Nov 29 2020 - 21:03:24 EST


On 11/29/20 5:44 PM, Sergey Senozhatsky wrote:
> Some functions that are declared when CONFIG_POSIX_ACL is defined
> are not declared when CONFIG_POSIX_ACL is not defined. Add the
> missing ones:
> set_posix_acl(), posix_acl_update_mode(), get_cached_acl(),
> get_cached_acl_rcu(), set_cached_acl(), forget_cached_acl().
>
> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@xxxxxxxxx>

Hi,

I can't find CONFIG_POSIX_ACL in the kernel source tree.
Should it be CONFIG_FS_POSIX_ACL ?

How did you test this?

> ---
> include/linux/posix_acl.h | 33 +++++++++++++++++++++++++++++++++
> 1 file changed, 33 insertions(+)
>
> diff --git a/include/linux/posix_acl.h b/include/linux/posix_acl.h
> index 90797f1b421d..f6d206359da5 100644
> --- a/include/linux/posix_acl.h
> +++ b/include/linux/posix_acl.h
> @@ -117,6 +117,39 @@ static inline int posix_acl_create(struct inode *inode, umode_t *mode,
> static inline void forget_all_cached_acls(struct inode *inode)
> {
> }
> +
> +static inline int set_posix_acl(struct inode *inode, int type,
> + struct posix_acl *acl)
> +{
> + return 0;
> +}
> +
> +static inline int posix_acl_update_mode(struct inode *, umode_t *,
> + struct posix_acl **)
> +{
> + return 0;
> +}
> +
> +static inline struct posix_acl *get_cached_acl(struct inode *inode,
> + int type)
> +{
> + return NULL;
> +}
> +
> +static inline struct posix_acl *get_cached_acl_rcu(struct inode *inode,
> + int type)
> +{
> + return NULL;
> +}
> +
> +static inline void set_cached_acl(struct inode *inode, int type,
> + struct posix_acl *acl)
> +{
> +}
> +
> +static inline void forget_cached_acl(struct inode *inode, int type)
> +{
> +}
> #endif /* CONFIG_FS_POSIX_ACL */
>
> struct posix_acl *get_acl(struct inode *inode, int type);
>

thanks.
--
~Randy