Re: [PATCH AUTOSEL 5.9 22/33] vhost scsi: add lun parser helper

[Sasha Levin]

On Wed, Nov 25, 2020 at 07:08:54PM +0100, Paolo Bonzini wrote:
> On 25/11/20 19:01, Sasha Levin wrote:
> > On Wed, Nov 25, 2020 at 06:48:21PM +0100, Paolo Bonzini wrote:
> > > On 25/11/20 16:35, Sasha Levin wrote:
> > > > From: Mike Christie <michael.christie@xxxxxxxxxx>
> > > >
> > > > [ Upstream commit 18f1becb6948cd411fd01968a0a54af63732e73c ]
> > > >
> > > > Move code to parse lun from req's lun_buf to helper, so tmf code
> > > > can use it in the next patch.
> > > >
> > > > Signed-off-by: Mike Christie <michael.christie@xxxxxxxxxx>
> > > > Reviewed-by: Paolo Bonzini <pbonzini@xxxxxxxxxx>
> > > > Acked-by: Jason Wang <jasowang@xxxxxxxxxx>
> > > > Link: https://lore.kernel.org/r/1604986403-4931-5-git-send-email-michael.christie@xxxxxxxxxx
> > > >
> > > > Signed-off-by: Michael S. Tsirkin <mst@xxxxxxxxxx>
> > > > Acked-by: Stefan Hajnoczi <stefanha@xxxxxxxxxx>
> > > > Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>
> > >
> > > This doesn't seem like stable material, does it?
> >
> > It went in as a dependency for efd838fec17b ("vhost scsi: Add support
> > for LUN resets."), which is the next patch.
>
> Which doesn't seem to be suitable for stable either...  Patch 3/5 in 

Why not? It was sent as a fix to Linus.

> the series might be (vhost scsi: fix cmd completion race), so I can 
> understand including 1/5 and 2/5 just in case, but not the rest.  Does 
> the bot not understand diffstats?

Not on their own, no. What's wrong with the diffstats?

--
Thanks,
Sasha