Re: [PATCH 1/1] perf diff: fix error return value in __cmd_diff()

From: Arnaldo Carvalho de Melo
Date: Fri Nov 27 2020 - 12:25:48 EST


Em Fri, Nov 27, 2020 at 02:22:02PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Fri, Nov 27, 2020 at 10:35:37PM +0900, Namhyung Kim escreveu:
> > On Tue, Nov 24, 2020 at 7:37 PM Zhen Lei <thunder.leizhen@xxxxxxxxxx> wrote:

> > > An appropriate return value should be set on the failed path.

> > > Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> > > Signed-off-by: Zhen Lei <thunder.leizhen@xxxxxxxxxx>

> > Acked-by: Namhyung Kim <namhyung@xxxxxxxxxx>

> Thanks, applied.

I also added this:

Cc: Jin Yao <yao.jin@xxxxxxxxxxxxxxx>
Fixes: 2a09a84c720b436a ("perf diff: Support hot streams comparison")

Please add the fixes line and CC the author of the patch introducing the
bug next time,

Thanks

- Arnaldo