Re: [PATCH] media: vb2: always set buffer cache sync hints
From: Tomasz Figa
Date: Fri Nov 27 2020 - 11:50:45 EST
On Sat, Nov 28, 2020 at 1:35 AM Sergey Senozhatsky
<sergey.senozhatsky@xxxxxxxxx> wrote:
>
> On (20/11/27 15:56), Hans Verkuil wrote:
> > Yes.
> >
> > BTW, wouldn't it be sufficient to change this code to:
> >
> > if (!q->allow_cache_hints && q->memory != VB2_MEMORY_DMABUF) {
> > vb->need_cache_sync_on_prepare = 1;
> > vb->need_cache_sync_on_finish = 1;
> > }
>
> I think it would be sufficient.
Does it matter at this point if allow_cache_hints is set or not?
Best regards,
Tomasz