Re: [PATCH bpf-next v3 1/6] net: Remove the err argument from sock_from_file

[KP Singh]

On Thu, Nov 26, 2020 at 5:45 PM Florent Revest <revest@xxxxxxxxxxxx> wrote:
>
> Currently, the sock_from_file prototype takes an "err" pointer that is
> either not set or set to -ENOTSOCK IFF the returned socket is NULL. This
> makes the error redundant and it is ignored by a few callers.
>
> This patch simplifies the API by letting callers deduce the error based
> on whether the returned socket is NULL or not.
>
> Suggested-by: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
> Signed-off-by: Florent Revest <revest@xxxxxxxxxx>

Reviewed-by: KP Singh <kpsingh@xxxxxxxxxx>