Re: [PATCH] parisc: signal: remove _SA_SIGGFAULT

From: Helge Deller
Date: Thu Nov 26 2020 - 09:46:55 EST


On 11/26/20 2:06 PM, Anders Roxell wrote:
> When building tinyconfig on parisc the following error shows up:
>
> /tmp/kernel/signal.c: In function 'do_sigaction':
> /tmp/arch/parisc/include/asm/signal.h:24:30: error: '_SA_SIGGFAULT' undeclared (first use in this function); did you mean 'SIL_FAULT'?
> #define __ARCH_UAPI_SA_FLAGS _SA_SIGGFAULT
> ^~~~~~~~~~~~~
>
> The changes in the two individual patches listed in 'Fixes' below are
> OK. Remove the _SA_SIGGFAULT define since PH-UX isn't going to be
> supported according to commit 41f5a81c07cd ("parisc: Drop HP-UX specific
> fcntl and signal flags").
>
> Fixes: 23acdc76f179 ("signal: clear non-uapi flag bits when passing/returning sa_flags")
> Fixes: 41f5a81c07cd ("parisc: Drop HP-UX specific fcntl and signal flags")
> Signed-off-by: Anders Roxell <anders.roxell@xxxxxxxxxx>
> ---
> arch/parisc/include/asm/signal.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/parisc/include/asm/signal.h b/arch/parisc/include/asm/signal.h
> index 30dd1e43ef88..715c96ba2ec8 100644
> --- a/arch/parisc/include/asm/signal.h
> +++ b/arch/parisc/include/asm/signal.h
> @@ -21,8 +21,6 @@ typedef struct {
> unsigned long sig[_NSIG_WORDS];
> } sigset_t;
>
> -#define __ARCH_UAPI_SA_FLAGS _SA_SIGGFAULT
> -

Which kernel are you testing?
I don't see this line in current git head...?!?

Helge

> #include <asm/sigcontext.h>
>
> #endif /* !__ASSEMBLY */
>