Re: [PATCH V4 4/6] PCI: tegra: Continue unconfig sequence even if parts fail

From: Thierry Reding
Date: Thu Nov 26 2020 - 06:35:04 EST


On Mon, Nov 09, 2020 at 10:49:35PM +0530, Vidya Sagar wrote:
> Currently the driver checks for error value of different APIs during the
> uninitialization sequence. It just returns from there if there is any error
> observed for one of those calls. Comparatively it is better to continue the
> uninitialization sequence irrespective of whether some of them are
> returning error. That way, it is more closer to complete uninitialization.
>
> Signed-off-by: Vidya Sagar <vidyas@xxxxxxxxxx>
> ---
> V4:
> * None
>
> V3:
> * Modified subject as per Bjorn's suggestion
> * Removed tegra_pcie_init_controller()'s error checking part and pushed
> a separate patch for it
>
> V2:
> * None
>
> drivers/pci/controller/dwc/pcie-tegra194.c | 39 +++++++++-------------
> 1 file changed, 15 insertions(+), 24 deletions(-)

Tested-by: Thierry Reding <treding@xxxxxxxxxx>
Acked-by: Thierry Reding <treding@xxxxxxxxxx>

Attachment: signature.asc
Description: PGP signature