Re: [PATCH] microblaze: Remove noMMU code

[Michal Simek]

Hi Mike,

On 25. 11. 20 13:07, Mike Rapoport wrote:
> On Wed, Nov 25, 2020 at 12:30:32PM +0100, Michal Simek wrote:
>> This configuration is obsolete and likely none is really using it. That's
>> why remove it to simplify code.
>>
>> Cc: Arnd Bergmann <arnd@xxxxxxxx>
>> Signed-off-by: Michal Simek <michal.simek@xxxxxxxxxx>
>> ---
> 
> Looks ok to me except several leftovers:
> 
> $ git grep CONFIG_MMU arch/microblaze/
> arch/microblaze/kernel/hw_exception_handler.S: * STACK FRAME STRUCTURE (for CONFIG_MMU=n)
> 
> $ git grep -E 'MICROBLAZE_(64|16)K_PAGES'
> arch/microblaze/include/asm/page.h:#if defined(CONFIG_MICROBLAZE_64K_PAGES)
> arch/microblaze/include/asm/page.h:#elif defined(CONFIG_MICROBLAZE_16K_PAGES)
> arch/microblaze/kernel/hw_exception_handler.S:#ifdef CONFIG_MICROBLAZE_64K_PAGES
> arch/microblaze/kernel/hw_exception_handler.S:#elif CONFIG_MICROBLAZE_16K_PAGES
> drivers/net/Kconfig:                 IA64_PAGE_SIZE_64KB || MICROBLAZE_64K_PAGES || \
> 
> 

I left it there intentionally. First one because there is description in
that comment which references noMMU. If this should be removed the whole
comment should be tuned to make sense. It is better to do it in separate
patch.

And second part. I know I removed that Kconfig macros for it but maybe
good to talk about what needs to change to support different page size
for systems with MMU.

Thanks,
Michal