Re: [PATCH 1/1] ktest.pl: Fix incorrect reboot for grub2bls

[Steven Rostedt]

On Fri, 20 Nov 2020 23:12:17 -0500
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> On Fri, 20 Nov 2020 18:12:43 -0800
> Libo Chen <libo.chen@xxxxxxxxxx> wrote:
> 
> > This issue was first noticed when I was testing different kernels on
> > Oracle Linux 8 which as Fedora 30+ adopts BLS as default. Even though a
> > kernel entry was added successfully and the index of that kernel entry was
> > retrieved correctly, ktest still wouldn't reboot the system into
> > user-specified kernel.
> > 
> > The bug was spotted in subroutine reboot_to where the if-statement never
> > checks for REBOOT_TYPE "grub2bls", therefore the desired entry will not be
> > set for the next boot.
> > 
> > Add a check for "grub2bls" so that $grub_reboot $grub_number can
> > be run before a reboot if REBOOT_TYPE is "grub2bls" then we can boot to
> > the correct kernel.
> > 
> > Fixes: ac2466456eaa ("ktest: introduce grub2bls REBOOT_TYPE option")  
> 
> I was just thinking a couple of hours ago if anyone uses ktest.pl, and
> if so, how come I haven't received any patches for it ;-)
> 
> Anyway, I'll take a look at this next week, and it may be a while
> before it gets into the kernel, as I like to run updates for a few
> weeks on my systems (as I use it to build all my kernels), before I
> push it upstream.
> 

Well, I didn't quite get to it this week, and I'm taking the rest of
the week off. Hopefully, I'll be able to look at it when I get back.

Thanks!

-- Steve