Re: [RFC PATCH v2] tracing: Remove duplicate `type` field from regmap `regcache_sync` trace event

From: Steven Rostedt
Date: Tue Nov 24 2020 - 10:49:27 EST


On Tue, 24 Nov 2020 08:57:30 -0500
Philippe Duplessis-Guindon <pduplessis@xxxxxxxxxxxx> wrote:

> I have an error saying that `regcache_sync` has 2 fields named `type`
> while using libtraceevent.
>
> Erase the `int field` type, which is not assigned. This field is
> introduced by mistake and this commit removes it.
>
> Fixes commit 593600890110c ("regmap: Add the regcache_sync trace event")
>
> Signed-off-by: Philippe Duplessis-Guindon <pduplessis@xxxxxxxxxxxx>

Reviewed-by: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx>

-- Steve

> ---
> drivers/base/regmap/trace.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/base/regmap/trace.h b/drivers/base/regmap/trace.h
> index d4066fa079ab..9abee14df9ee 100644
> --- a/drivers/base/regmap/trace.h
> +++ b/drivers/base/regmap/trace.h
> @@ -126,7 +126,6 @@ TRACE_EVENT(regcache_sync,
> __string( name, regmap_name(map) )
> __string( status, status )
> __string( type, type )
> - __field( int, type )
> ),
>
> TP_fast_assign(