Re: [PATCH] mm/gup_benchmark: mark gup_benchmark_init as __init function

From: Jason Gunthorpe
Date: Thu Nov 05 2020 - 14:52:39 EST


On Tue, Nov 03, 2020 at 09:10:16PM +1300, Barry Song wrote:
> gup_benchmark_init() is only called during initialization, mark it as
> __init to save some memory.
>
> Cc: John Hubbard <jhubbard@xxxxxxxxxx>
> Cc: Jan Kara <jack@xxxxxxx>
> Cc: Jérôme Glisse <jglisse@xxxxxxxxxx>
> Cc: "Matthew Wilcox (Oracle)" <willy@xxxxxxxxxxxxx>
> Cc: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
> Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>
> Cc: Dan Williams <dan.j.williams@xxxxxxxxx>
> Cc: Dave Chinner <david@xxxxxxxxxxxxx>
> Cc: Jason Gunthorpe <jgg@xxxxxxxx>
> Cc: Jonathan Corbet <corbet@xxxxxxx>
> Cc: Michal Hocko <mhocko@xxxxxxxx>
> Cc: Mike Kravetz <mike.kravetz@xxxxxxxxxx>
> Cc: Shuah Khan <shuah@xxxxxxxxxx>
> Cc: Vlastimil Babka <vbabka@xxxxxxx>
> Signed-off-by: Barry Song <song.bao.hua@xxxxxxxxxxxxx>
> ---
> mm/gup_benchmark.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Hardly seems worthwhile, but looks correct

Reviewed-by: Jason Gunthorpe <jgg@xxxxxxxxxx>

Jason