Re: [PATCH] mmc: meson-gx: drop of_match_ptr from of_device_id table

[Ulf Hansson]

On Tue, 3 Nov 2020 at 17:30, Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
>
> The driver can match only via the DT table so the table should be always
> used and the of_match_ptr does not have any sense (this also allows ACPI
> matching via PRP0001, even though it is not relevant here).  This fixes
> compile warning (!CONFIG_OF && !CONFIG_MODULES):
>
>     drivers/mmc/host/meson-gx-mmc.c:1252:34: warning:
>         ‘meson_mmc_of_match’ defined but not used [-Wunused-const-variable=]
>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>

Applied for next, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/host/meson-gx-mmc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
> index 4ec41579940a..13f6a2c0ed04 100644
> --- a/drivers/mmc/host/meson-gx-mmc.c
> +++ b/drivers/mmc/host/meson-gx-mmc.c
> @@ -1265,7 +1265,7 @@ static struct platform_driver meson_mmc_driver = {
>         .driver         = {
>                 .name = DRIVER_NAME,
>                 .probe_type = PROBE_PREFER_ASYNCHRONOUS,
> -               .of_match_table = of_match_ptr(meson_mmc_of_match),
> +               .of_match_table = meson_mmc_of_match,
>         },
>  };
>
> --
> 2.25.1
>