Re: [PATCH v5 1/3] dt-bindings: dmaengine: Document qcom,gpi dma binding

From: Rob Herring
Date: Wed Nov 04 2020 - 14:02:42 EST


On Tue, 03 Nov 2020 16:55:42 +0530, Vinod Koul wrote:
> Add devicetree binding documentation for GPI DMA controller
> implemented on Qualcomm SoCs
>
> Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
> Signed-off-by: Vinod Koul <vkoul@xxxxxxxxxx>
> ---
> .../devicetree/bindings/dma/qcom,gpi.yaml | 90 +++++++++++++++++++
> include/dt-bindings/dma/qcom-gpi.h | 11 +++
> 2 files changed, 101 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/dma/qcom,gpi.yaml
> create mode 100644 include/dt-bindings/dma/qcom-gpi.h
>


My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/dma/qcom,gpi.yaml: properties: {'enum': ['$ref', 'additionalItems', 'additionalProperties', 'allOf', 'anyOf', 'const', 'contains', 'default', 'dependencies', 'deprecated', 'description', 'else', 'enum', 'if', 'items', 'maxItems', 'maximum', 'minItems', 'minimum', 'multipleOf', 'not', 'oneOf', 'pattern', 'patternProperties', 'properties', 'propertyNames', 'required', 'then', 'unevaluatedProperties']} is not allowed for 'additionalProperties'
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/dma/qcom,gpi.yaml: ignoring, error in schema: properties
warning: no schema found in file: ./Documentation/devicetree/bindings/dma/qcom,gpi.yaml


See https://patchwork.ozlabs.org/patch/1392940

The base for the patch is generally the last rc1. Any dependencies
should be noted.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.