Re: [PATCH v4 3/8] rpmsg: Move structure rpmsg_ns_msg to header file

From: Mathieu Poirier
Date: Wed Nov 04 2020 - 12:30:25 EST


On Tue, Nov 03, 2020 at 05:32:26PM +0100, Guennadi Liakhovetski wrote:
> Hi Mathieu,
>
> On Tue, Oct 27, 2020 at 11:52:13AM -0600, Mathieu Poirier wrote:
> > Move structure rpmsg_ns_msg to its own header file so that
> > it can be used by other entities.
> >
> > Signed-off-by: Mathieu Poirier <mathieu.poirier@xxxxxxxxxx>
> > Reviewed-by: Arnaud Pouliquen <arnaud.pouliquen@xxxxxx>
> > ---
> > drivers/rpmsg/virtio_rpmsg_bus.c | 32 +-----------------------
> > include/linux/rpmsg_ns.h | 42 ++++++++++++++++++++++++++++++++
>
> Sorry for a delayed comment, it just occurred to me: there is a
> include/linux/rpmsg directory already, so, perhaps it would be
> better to place the new headers there as include/linux/rpmsg/ns.h
> and include/linux/rpmsg/byteorder.h?

Yes - I think that's a good suggestion.

>
> Thanks
> Guennadi