Re: [PATCH] ASoC: rt715:add Mic Mute LED control support

From: kernel test robot
Date: Tue Nov 03 2020 - 14:04:11 EST


Hi Perry,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on asoc/for-next]
[also build test ERROR on v5.10-rc2 next-20201103]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Perry-Yuan/ASoC-rt715-add-Mic-Mute-LED-control-support/20201103-210037
base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
config: m68k-randconfig-r021-20201103 (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/7907f123e41159e71a0151518d1018dce3c5656d
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Perry-Yuan/ASoC-rt715-add-Mic-Mute-LED-control-support/20201103-210037
git checkout 7907f123e41159e71a0151518d1018dce3c5656d
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

m68k-linux-ld: sound/soc/codecs/rt715.o: in function `rt715_micmute_led_mode_put':
>> sound/soc/codecs/rt715.c:248: undefined reference to `ledtrig_audio_set'
m68k-linux-ld: sound/soc/codecs/rt715.o: in function `rt715_mic_mute_led_mode_get':
sound/soc/codecs/rt715.c:233: undefined reference to `ledtrig_audio_set'

vim +248 sound/soc/codecs/rt715.c

238
239 static int rt715_micmute_led_mode_put(struct snd_kcontrol *kcontrol,
240 struct snd_ctl_elem_value *ucontrol)
241 {
242 struct snd_soc_component *component = snd_kcontrol_chip(kcontrol);
243 struct rt715_priv *rt715 = snd_soc_component_get_drvdata(component);
244 int led_mode = ucontrol->value.integer.value[0];
245
246 rt715->micmute_led = led_mode;
247 #if IS_ENABLED(CONFIG_LEDS_TRIGGER_AUDIO)
> 248 ledtrig_audio_set(LED_AUDIO_MICMUTE,
249 rt715->micmute_led ? LED_ON : LED_OFF);
250 #endif
251 return 0;
252 }
253

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip