Re: [PATCH v1] PCI: brcmstb: variable is missing proper initialization

From: Nicolas Saenz Julienne
Date: Tue Nov 03 2020 - 12:32:59 EST


On Mon, 2020-11-02 at 13:07 -0800, Florian Fainelli wrote:
>
> On 11/2/2020 12:57 PM, Jim Quinlan wrote:
> > The variable 'tmp' is used multiple times in the brcm_pcie_setup()
> > function. One such usage did not initialize 'tmp' to the current value of
> > the target register. By luck the mistake does not currently affect
> > behavior; regardless 'tmp' is now initialized properly.
> >
> > Fixes: c0452137034b ("PCI: brcmstb: Add Broadcom STB PCIe host controller driver")
> > Suggested-by: Rafał Miłecki <zajec5@xxxxxxxxx>
> > Signed-off-by: Jim Quinlan <james.quinlan@xxxxxxxxxxxx>

Acked-by: Nicolas Saenz Julienne <nsaenzjulienne@xxxxxxx>

Attachment: signature.asc
Description: This is a digitally signed message part