Re: [RFC PATCH 1/3] RISC-V: Add Microchip PolarFire SoC kconfig option

From: Bin Meng
Date: Tue Nov 03 2020 - 04:55:24 EST


On Thu, Oct 29, 2020 at 6:00 PM Atish Patra <atish.patra@xxxxxxx> wrote:
>
> Add Microchip PolarFire kconfig option which selects SoC specific
> and common drivers that is required for this SoC.
>
> Signed-off-by: Atish Patra <atish.patra@xxxxxxx>
> ---
> arch/riscv/Kconfig.socs | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/riscv/Kconfig.socs b/arch/riscv/Kconfig.socs
> index 8a55f6156661..74d07250ecc5 100644
> --- a/arch/riscv/Kconfig.socs
> +++ b/arch/riscv/Kconfig.socs
> @@ -22,6 +22,13 @@ config SOC_VIRT
> help
> This enables support for QEMU Virt Machine.
>
> +config SOC_MICROCHIP_POLARFIRE

Please put this in the alphabetical order

> + bool "Microchip PolarFire SoCs"
> + select MCHP_CLK_PFSOC
> + select SIFIVE_PLIC
> + help
> + This enables support for Microchip PolarFire SoC platforms.
> +
> config SOC_KENDRYTE
> bool "Kendryte K210 SoC"
> depends on !MMU
> --

Otherwise LGTM
Reviewed-by: Bin Meng <bin.meng@xxxxxxxxxxxxx>