Re: [PATCH net-next 02/13] octeontx2-af: Verify MCAM entry channel and PF_FUNC

From: Naveen Mamindlapalli
Date: Tue Nov 03 2020 - 00:06:29 EST


Hi Jakub,

> -----Original Message-----
> From: Jakub Kicinski <kuba@xxxxxxxxxx>
> Sent: Monday, November 2, 2020 11:23 PM
> To: Naveen Mamindlapalli <naveenm@xxxxxxxxxxx>
> Cc: netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> davem@xxxxxxxxxxxxx; Sunil Kovvuri Goutham <sgoutham@xxxxxxxxxxx>; Linu
> Cherian <lcherian@xxxxxxxxxxx>; Geethasowjanya Akula
> <gakula@xxxxxxxxxxx>; Jerin Jacob Kollanukkaran <jerinj@xxxxxxxxxxx>;
> Subbaraya Sundeep Bhatta <sbhatta@xxxxxxxxxxx>; Hariprasad Kelam
> <hkelam@xxxxxxxxxxx>; Kiran Kumar Kokkilagadda
> <kirankumark@xxxxxxxxxxx>
> Subject: Re: [PATCH net-next 02/13] octeontx2-af: Verify MCAM entry
> channel and PF_FUNC
>
> On Mon, 2 Nov 2020 11:41:11 +0530 Naveen Mamindlapalli wrote:
> > From: Subbaraya Sundeep <sbhatta@xxxxxxxxxxx>
> >
> > This patch adds support to verify the channel number sent by mailbox
> > requester before writing MCAM entry for Ingress packets.
> > Similarly for Egress packets, verifying the PF_FUNC sent by the
> > mailbox user.
> >
> > Signed-off-by: Subbaraya Sundeep <sbhatta@xxxxxxxxxxx>
> > Signed-off-by: Kiran Kumar K <kirankumark@xxxxxxxxxxx>
> > Signed-off-by: Sunil Goutham <sgoutham@xxxxxxxxxxx>
> > Signed-off-by: Naveen Mamindlapalli <naveenm@xxxxxxxxxxx>
>
> drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c:81:17: warning: incorrect
> type in assignment (different base types)
> drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c:81:17: expected
> unsigned short [assigned] [usertype] pf_func
> drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c:81:17: got restricted
> __be16 [usertype]

I will fix these warnings in v2

Thanks,
Naveen