Re: [PATCH] ath9k: revert "ath9k: hif_usb: fix race condition between usb_get_urb() and usb_kill_anchored_urbs()"

From: Kalle Valo
Date: Mon Nov 02 2020 - 13:23:14 EST


Brooke Basile <brookebasile@xxxxxxxxx> wrote:

> A bug in USB/IP previously caused all syzkaller USB fuzzing instances to
> return false positives when testing crash reproducers.
> This patch reverts changes made in commit 03fb92a432ea which, due to
> this bug, returned false positives when tested and introduced new
> regressions.
>
> Fixes: 03fb92a432ea ("ath9k: hif_usb: fix race condition between usb_get_urb() and usb_kill_anchored_urbs()")
> Signed-off-by: Brooke Basile <brookebasile@xxxxxxxxx>

More background info is needed so that I'm not reverting the revert soon. What
were the new regressions? Do you have a pointer to the discussion? All this
should be in the commit log. But I can add those, just provide them in this
thread.

--
https://patchwork.kernel.org/project/linux-wireless/patch/20201012220809.23225-1-brookebasile@xxxxxxxxx/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches