Re: [PATCH net-next 03/13] octeontx2-af: Generate key field bit mask from KEX profile

From: Jakub Kicinski
Date: Mon Nov 02 2020 - 12:53:46 EST


On Mon, 2 Nov 2020 11:41:12 +0530 Naveen Mamindlapalli wrote:
> From: Subbaraya Sundeep <sbhatta@xxxxxxxxxxx>
>
> Key Extraction(KEX) profile decides how the packet metadata such as
> layer information and selected packet data bytes at each layer are
> placed in MCAM search key. This patch reads the configured KEX profile
> parameters to find out the bit position and bit mask for each field.
> The information is used when programming the MCAM match data by SW
> to match a packet flow and take appropriate action on the flow. This
> patch also verifies the mandatory fields such as channel and DMAC
> are not overwritten by the KEX configuration of other fields.
>
> Signed-off-by: Subbaraya Sundeep <sbhatta@xxxxxxxxxxx>
> Signed-off-by: Sunil Goutham <sgoutham@xxxxxxxxxxx>
> Signed-off-by: Naveen Mamindlapalli <naveenm@xxxxxxxxxxx>

Lots of new warnings like this here:

drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c:351:38: warning: implicit conversion from ‘enum header_fields’ to ‘enum key_fields’ [-Wenum-conversion]
351 | if (npc_check_overlap(rvu, blkaddr, NPC_ETYPE, start_lid, intf))
| ^~~~~~~~~