Re: [RESEND] venus: fix calculating mbps in calculate_inst_freq()

From: vgarodia
Date: Mon Nov 02 2020 - 10:39:19 EST


Hi Mansur,

On 2020-11-02 16:01, Mansur Alisha Shaik wrote:
Currently in calculate_inst_freq(), video driver is calculating
macro blocks per frame in stead of macro blocks per second(mpbs).
instead

Which results frequency is always setting to lower frequency (150MB)
as per frequency table for sc7180. Hence the playback is not smooth.
150MHz


Corrected this by correcting the mbps calculation in calculate_inst_freq().

Signed-off-by: Mansur Alisha Shaik <mansur@xxxxxxxxxxxxxx>
---
drivers/media/platform/qcom/venus/pm_helpers.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/platform/qcom/venus/pm_helpers.c
b/drivers/media/platform/qcom/venus/pm_helpers.c
index 57877ea..001513f 100644
--- a/drivers/media/platform/qcom/venus/pm_helpers.c
+++ b/drivers/media/platform/qcom/venus/pm_helpers.c
@@ -928,7 +928,7 @@ static unsigned long calculate_inst_freq(struct
venus_inst *inst,
u32 fps = (u32)inst->fps;
u32 mbs_per_sec;

- mbs_per_sec = load_per_instance(inst) / fps;
+ mbs_per_sec = load_per_instance(inst);

Good find.

Thanks,
Vikash