RE: [EXT] [PATCH] scsi: bnx2fc: remove unneeded semicolon

From: Saurav Kashyap
Date: Sun Nov 01 2020 - 23:44:30 EST


Hi Tom,

> -----Original Message-----
> From: trix@xxxxxxxxxx <trix@xxxxxxxxxx>
> Sent: Sunday, November 1, 2020 8:08 PM
> To: Saurav Kashyap <skashyap@xxxxxxxxxxx>; Javed Hasan
> <jhasan@xxxxxxxxxxx>; jejb@xxxxxxxxxxxxx; martin.petersen@xxxxxxxxxx
> Cc: GR-QLogic-Storage-Upstream <GR-QLogic-Storage-
> Upstream@xxxxxxxxxxx>; linux-scsi@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; Tom Rix <trix@xxxxxxxxxx>
> Subject: [EXT] [PATCH] scsi: bnx2fc: remove unneeded semicolon
>
> External Email
>
> ----------------------------------------------------------------------
> From: Tom Rix <trix@xxxxxxxxxx>
>
> A semicolon is not needed after a switch statement.
>
> Signed-off-by: Tom Rix <trix@xxxxxxxxxx>
> ---
> drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
> b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
> index 6890bbe04a8c..a436adb6092d 100644
> --- a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
> +++ b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
> @@ -2275,7 +2275,7 @@ static int bnx2fc_ctlr_enabled(struct
> fcoe_ctlr_device *cdev)
> case FCOE_CTLR_UNUSED:
> default:
> return -ENOTSUPP;
> - };
> + }
> }

Thanks for a patch.

Reviewed-by: Saurav Kashyap <skashyap@xxxxxxxxxxx>

Thanks,
~Saurav
>
> enum bnx2fc_create_link_state {
> --
> 2.18.1