Re: [PATCH v2] counter/ti-eqep: Fix regmap max_register

From: Jonathan Cameron
Date: Sun Nov 01 2020 - 12:18:59 EST


On Sun, 25 Oct 2020 11:51:22 -0500
David Lechner <david@xxxxxxxxxxxxxx> wrote:

> The values given were the offset of the register after the last
> register instead of the actual last register in each range. Fix
> by using the correct last register of each range.
>
> Fixes: f213729f6796 ("counter: new TI eQEP driver")
> Signed-off-by: David Lechner <david@xxxxxxxxxxxxxx>
> Acked-by: William Breathitt Gray <vilhelm.gray@xxxxxxxxx>
Applied to the fixes-togreg branch of iio.git and marked for stable.

Thanks,

Jonathan

> ---
>
> v2 changes:
> * add Fixes: tag
> * picked up Acked-by:
>
> drivers/counter/ti-eqep.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/counter/ti-eqep.c b/drivers/counter/ti-eqep.c
> index 1ff07faef27f..5d6470968d2c 100644
> --- a/drivers/counter/ti-eqep.c
> +++ b/drivers/counter/ti-eqep.c
> @@ -368,7 +368,7 @@ static const struct regmap_config ti_eqep_regmap32_config = {
> .reg_bits = 32,
> .val_bits = 32,
> .reg_stride = 4,
> - .max_register = 0x24,
> + .max_register = QUPRD,
> };
>
> static const struct regmap_config ti_eqep_regmap16_config = {
> @@ -376,7 +376,7 @@ static const struct regmap_config ti_eqep_regmap16_config = {
> .reg_bits = 16,
> .val_bits = 16,
> .reg_stride = 2,
> - .max_register = 0x1e,
> + .max_register = QCPRDLAT,
> };
>
> static int ti_eqep_probe(struct platform_device *pdev)