Re: [PATCH v4 10/15] ASoC: dt-bindings: tegra: Add graph bindings

[Sameer Pujar]

> > Add device tree binding properties of generic graph to ASoC component
> > devices. This allows to define audio ports out of these components or
> > DAIs and audio graph based sound card can be realised with this.
> >
> > Signed-off-by: Sameer Pujar <spujar@xxxxxxxxxx>
> > ---
> >   Documentation/devicetree/bindings/sound/nvidia,tegra186-dspk.yaml  | 7 +++++++
> >   .../devicetree/bindings/sound/nvidia,tegra210-admaif.yaml          | 7 +++++++
> >   Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml  | 7 +++++++
> >   Documentation/devicetree/bindings/sound/nvidia,tegra210-dmic.yaml  | 7 +++++++
> >   Documentation/devicetree/bindings/sound/nvidia,tegra210-i2s.yaml   | 7 +++++++
> >   5 files changed, 35 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra186-dspk.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra186-dspk.yaml
> > index ed2fb32..23875b1 100644
> > --- a/Documentation/devicetree/bindings/sound/nvidia,tegra186-dspk.yaml
> > +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra186-dspk.yaml
> > @@ -55,6 +55,13 @@ properties:
> >         The name can be "DSPK1" or "DSPKx", where x depends on the maximum
> >         available instances on a Tegra SoC.
> >
> > +  ports:
> > +    $ref: /schemas/sound/audio-graph-card.yaml#/definitions/ports
> > +

> > +patternProperties:
> > +  "^port(@[0-9a-f]+)?$":
> > +    $ref: /schemas/sound/audio-graph-card.yaml#/definitions/port
> You should have either 'ports' or a single 'port' (yes, the graph
> binding allowed multiple port nodes without 'ports', but that should be
> deprecated IMO)

OK, will drop this and just use 'port' here.