Re: [PATCH] gpiolib: cdev: switch from kstrdup() to kstrndup()

From: Linus Walleij
Date: Wed Oct 07 2020 - 05:31:50 EST


On Mon, Oct 5, 2020 at 9:03 AM Kent Gibson <warthog618@xxxxxxxxx> wrote:

> Use kstrndup() to copy line labels from the userspace provided char
> array, rather than ensuring the char array contains a null terminator
> and using kstrdup().
>
> Note that the length provided to kstrndup() still assumes that the char
> array does contain a null terminator, so the maximum string length is one
> less than the array. This is consistent with the previous behaviour.
>
> Suggested-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
> Signed-off-by: Kent Gibson <warthog618@xxxxxxxxx>

General good practice! Patch applied.

Yours,
Linus Walleij