Re: [PATCH v4] checkpatch: add new warnings to author signoff checks.

From: Dwaipayan Ray
Date: Tue Oct 06 2020 - 15:01:35 EST


On Wed, Oct 7, 2020 at 12:25 AM Joe Perches <joe@xxxxxxxxxxx> wrote:
>
> On Wed, 2020-10-07 at 00:21 +0530, Dwaipayan Ray wrote:
> > The author signed-off-by checks are currently very vague.
> > Cases like same name or same address are not handled separately.
> >
> > For example, running checkpatch on commit be6577af0cef
> > ("parisc: Add atomic64_set_release() define to avoid CPU soft lockups"),
> > gives:
>
> Aren't you still missing emitting an message for cases like
>
> From: "J. Random Developer" <jrd@xxxxxxxxxxx>
> [...]
> Signed-off-by: "J. Random Developer" (BigCorp) <jrd@xxxxxxxxxxx>
>
> Where a comment does not match?
>
>

Yes, messages for comments were not emitted previously too
cause the same_email_address() function just matches name
and email (discarding name comments and email comments).

So should I add it to this patch, or should I work on it in a different
patch perhaps because it involves change on another subroutine?

Thanks,
Dwaipayan.